Skip to content

Conversation

@alexolinhager
Copy link

@alexolinhager alexolinhager commented Aug 7, 2025

Creates a new landice test case to generate a mesh for the Uummannaq Bay/Disko Bay region of GIS. Default .cfg file uses max_res_in_ocn capability from https://github.com/MPAS-Dev/compass/pull/894, so should be merged afterwards.

Checklist

  • User's Guide has been updated
  • Developer's Guide has been updated
  • API documentation in the Developer's Guide (api.rst) has any new or modified class, method and/or functions listed
  • Documentation has been built locally and changes look as expected
  • The E3SM-Project submodule has been updated with relevant E3SM changes
  • The MALI-Dev submodule has been updated with relevant MALI changes
  • Document (in a comment titled Testing in this PR) any testing that was used to verify the changes
  • New tests have been added to a test suite

# distance from ice margin to cull (km).
# Set to a value <= 0 if you do not want
# to cull based on distance from margin.
cull_distance = -.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be -1.0?

andrewdnolan and others added 14 commits October 28, 2025 14:46
Creates the option to maintain resolution in the ocean. Used to resolve
fjords and bathymetry when coupling to MPAS-Ocean.
This commit creates the option to maintain high resolution in all ocean
cells (same resolution as what is prescribed at outlet glacier termini).
This is necessary to resolve the fjord geometry that thermal forcing
parameterizations rely on. To reduce time when generating these higher
resolution meshes, this commit also introduces an option to do an
initial cull of the bedMachine dataset using the extent of the
contintental shelf before generating the GIS mesh.
This commit moves the calculation of geom_points and geom_edges
using a geojson of the gis contintental shelf extent
to compass/landice/tests/greenland/mesh.py, instead of
compass/landice/mesh.py. If this options is not being used, thn
geom_points and geom_edges are calculated within build_cell_width, as
per usual
Re-introduces code that sets a large cell width for cells that will be
culled by distance from ice edge. Only applied when not using a geojson
to pre-cull domain
Ensures the bedTopography constraint on mesh resolution is enforced
regardless 'max_res_in_ocn'. Instead, grid resolution in the ocean
is maximized following the bedTopgraphy constraint, overwritting it
where necessary.
Introduces new landice test case to generate a domain for the
Uummannaq/Disko Bay region of GIS.
Create region masks for each tidewater outlet glacier in domain
Addresses bug introduced by the inclusion of the parallel_executable
argument in interp_gridded2mali
Adds surface and basal mass balances fields and their respective
uncertainties to the uummmannaq/disko mesh_gen test case. used for the
dhdt albany optimization
@alexolinhager alexolinhager force-pushed the create_uummannaq_disko branch from 864d0c5 to 6fedb76 Compare October 28, 2025 22:05
@alexolinhager alexolinhager added the in progress This PR is not ready for review or merging label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in progress This PR is not ready for review or merging land ice

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants